[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

[GitBox]

lordcheng10 commented on code in PR #17797:
URL: https://github.com/apache/pulsar/pull/17797#discussion_r984174096


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -880,12 +881,22 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle bundle,
                                     for (NamespaceBundle sBundle : 
splittedBundles.getRight()) {
                                         
checkNotNull(ownershipCache.tryAcquiringOwnership(sBundle));
                                     }
+                                    updateNamespaceBundlesForPolicies(nsname, 
splittedBundles.getLeft())

Review Comment:
   It will retry!
   <img width="1265" alt="image" 
src="https://user-images.githubusercontent.com/19296967/193182665-d78af75c-a22f-4e6b-bfc4-22d4ca57c3af.png";>
   



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -880,12 +881,22 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle bundle,
                                     for (NamespaceBundle sBundle : 
splittedBundles.getRight()) {
                                         
checkNotNull(ownershipCache.tryAcquiringOwnership(sBundle));
                                     }
+                                    updateNamespaceBundlesForPolicies(nsname, 
splittedBundles.getLeft())

Review Comment:
   The maximum number of retry is 7 ：
   <img width="885" alt="image" 
src="https://user-images.githubusercontent.com/19296967/193182877-79600acf-7776-4264-95dc-593ad6a4e212.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org