AnonHxy commented on code in PR #17948:
URL: https://github.com/apache/pulsar/pull/17948#discussion_r990637827
##########
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java:
##########
@@ -55,15 +82,123 @@ public static SchemaHash of(SchemaData schemaData) {
}
public static SchemaHash of(SchemaInfo schemaInfo) {
- return of(schemaInfo == null ? new byte[0] : schemaInfo.getSchema(),
+ return of(schemaInfo == null ? null : schemaInfo.getSchema(),
schemaInfo == null ? null : schemaInfo.getType());
}
- public static SchemaHash of(byte[] schemaBytes, SchemaType schemaType) {
- return new SchemaHash(hashFunction.hashBytes(schemaBytes), schemaType);
+ public static SchemaHash empty() {
+ return of(null, null);
+ }
+
+ private static SchemaHash of(byte[] schemaBytes, SchemaType schemaType) {
+ SchemaHash result;
+ if (schemaBytes == null || schemaBytes.length == 0) {
+ result = EmptySchemaHashFactory.get(schemaType);
+ if (result == null) {
Review Comment:
One possible is that assume we add a new schemaType, but forget to add it in
the `EmptySchemaHashFactory `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
