coderzc commented on code in PR #17611: URL: https://github.com/apache/pulsar/pull/17611#discussion_r991334101
########## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java: ########## @@ -0,0 +1,628 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.delayed; + +import static com.google.common.base.Preconditions.checkArgument; +import static org.apache.bookkeeper.mledger.util.Futures.executeWithRetry; +import com.google.common.collect.HashBasedTable; +import com.google.common.collect.Range; +import com.google.common.collect.RangeMap; +import com.google.common.collect.Table; +import com.google.common.collect.TreeRangeMap; +import com.google.protobuf.ByteString; +import io.netty.util.Timeout; +import io.netty.util.Timer; +import java.time.Clock; +import java.util.ArrayList; +import java.util.BitSet; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; +import java.util.TreeSet; +import java.util.concurrent.CompletableFuture; +import javax.annotation.concurrent.ThreadSafe; +import lombok.SneakyThrows; +import lombok.extern.slf4j.Slf4j; +import org.apache.bookkeeper.mledger.ManagedCursor; +import org.apache.bookkeeper.mledger.ManagedLedgerException; +import org.apache.bookkeeper.mledger.impl.PositionImpl; +import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.mutable.MutableLong; +import org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.DelayedIndex; +import org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotMetadata; +import org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotSegment; +import org.apache.pulsar.broker.delayed.proto.DelayedMessageIndexBucketSnapshotFormat.SnapshotSegmentMetadata; +import org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers; +import org.apache.pulsar.common.util.FutureUtil; +import org.apache.pulsar.common.util.collections.TripleLongPriorityQueue; + +@Slf4j +@ThreadSafe +public class BucketDelayedDeliveryTracker extends InMemoryDelayedDeliveryTracker { + + public static final String DELAYED_BUCKET_KEY_PREFIX = "#pulsar.internal.delayed.bucket"; + + public static final String DELIMITER = "_"; + + private final long minIndexCountPerBucket; + + private final long timeStepPerBucketSnapshotSegment; + + private final int maxNumBuckets; + + private final ManagedCursor cursor; + + public final BucketSnapshotStorage bucketSnapshotStorage; + + private long numberDelayedMessages; + + private final Bucket lastMutableBucket; + + private final TripleLongPriorityQueue sharedBucketPriorityQueue; + + private final RangeMap<Long, Bucket> immutableBuckets; + + private final Table<Long, Long, Bucket> snapshotSegmentLastIndexTable; + + BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers dispatcher, + Timer timer, long tickTimeMillis, + boolean isDelayedDeliveryDeliverAtTimeStrict, + BucketSnapshotStorage bucketSnapshotStorage, + long minIndexCountPerBucket, long timeStepPerBucketSnapshotSegment, + int maxNumBuckets) { + this(dispatcher, timer, tickTimeMillis, Clock.systemUTC(), isDelayedDeliveryDeliverAtTimeStrict, + bucketSnapshotStorage, minIndexCountPerBucket, timeStepPerBucketSnapshotSegment, maxNumBuckets); + } + + BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers dispatcher, + Timer timer, long tickTimeMillis, Clock clock, + boolean isDelayedDeliveryDeliverAtTimeStrict, + BucketSnapshotStorage bucketSnapshotStorage, + long minIndexCountPerBucket, long timeStepPerBucketSnapshotSegment, + int maxNumBuckets) { + super(dispatcher, timer, tickTimeMillis, clock, isDelayedDeliveryDeliverAtTimeStrict); + this.minIndexCountPerBucket = minIndexCountPerBucket; + this.timeStepPerBucketSnapshotSegment = timeStepPerBucketSnapshotSegment; + this.maxNumBuckets = maxNumBuckets; + this.cursor = dispatcher.getCursor(); + this.sharedBucketPriorityQueue = new TripleLongPriorityQueue(); + this.immutableBuckets = TreeRangeMap.create(); + this.snapshotSegmentLastIndexTable = HashBasedTable.create(); + + this.bucketSnapshotStorage = bucketSnapshotStorage; + + numberDelayedMessages = recoverBucketSnapshot(); + + this.lastMutableBucket = new Bucket(-1L, -1L, new HashMap<>()); + } + + @SneakyThrows + private long recoverBucketSnapshot() { + List<CompletableFuture<Void>> completableFutures = new ArrayList<>(); + this.cursor.getCursorProperties().keySet().forEach(key -> { + if (key.startsWith(DELAYED_BUCKET_KEY_PREFIX)) { + String[] keys = key.split(DELIMITER); + checkArgument(keys.length == 3); + Bucket bucket = createImmutableBucket(Long.parseLong(keys[1]), Long.parseLong(keys[2])); + completableFutures.add(asyncLoadNextBucketSnapshotEntry(bucket, true)); + } + }); + + if (completableFutures.isEmpty()) { + return 0; + } + + FutureUtil.waitForAll(completableFutures).get(); + + MutableLong numberDelayedMessages = new MutableLong(0); + immutableBuckets.asMapOfRanges().values().forEach(bucket -> { + numberDelayedMessages.add(bucket.numberBucketDelayedMessages); + }); + + log.info("[{}] Recover delayed message index bucket snapshot finish, buckets: {}, numberDelayedMessages: {}", + dispatcher.getName(), immutableBuckets.asMapOfRanges().size(), numberDelayedMessages.getValue()); + + return numberDelayedMessages.getValue(); + } + + private void moveScheduledMessageToSharedQueue(long cutoffTime) { + TripleLongPriorityQueue priorityQueue = getPriorityQueue(); + while (!priorityQueue.isEmpty()) { + long timestamp = priorityQueue.peekN1(); + if (timestamp > cutoffTime) { + break; + } + + long ledgerId = priorityQueue.peekN2(); + long entryId = priorityQueue.peekN3(); + sharedBucketPriorityQueue.add(timestamp, ledgerId, entryId); + + priorityQueue.pop(); + } + } + + @Override + public void run(Timeout timeout) throws Exception { + synchronized (this) { + moveScheduledMessageToSharedQueue(getCutoffTime()); + } + super.run(timeout); + } + + private Optional<Bucket> findBucket(long ledgerId) { + if (immutableBuckets.asMapOfRanges().isEmpty()) { + return Optional.empty(); + } + + Range<Long> span = immutableBuckets.span(); + if (!span.contains(ledgerId)) { + return Optional.empty(); + } + return Optional.ofNullable(immutableBuckets.get(ledgerId)); + } + + private Long getBucketIdByBucketKey(String bucketKey) { + String bucketIdStr = cursor.getCursorProperties().get(bucketKey); + if (StringUtils.isBlank(bucketIdStr)) { + return null; + } + return Long.valueOf(bucketIdStr); + } + + private Bucket createImmutableBucket(long startLedgerId, long endLedgerId) { + Bucket newBucket = new Bucket(startLedgerId, endLedgerId, new HashMap<>()); + immutableBuckets.put(Range.closed(startLedgerId, endLedgerId), newBucket); + return newBucket; + } + + private CompletableFuture<Long> asyncSaveBucketSnapshot( + final String bucketKey, SnapshotMetadata snapshotMetadata, + List<SnapshotSegment> bucketSnapshotSegments) { + Long bucketId = getBucketIdByBucketKey(bucketKey); + checkArgument(bucketId == null); + + return bucketSnapshotStorage.createBucketSnapshot(snapshotMetadata, bucketSnapshotSegments) + .thenCompose(newBucketId -> putBucketKeyId(bucketKey, newBucketId)); + } + + private CompletableFuture<Long> putBucketKeyId(String bucketKey, Long bucketId) { + Objects.requireNonNull(bucketId); + return executeWithRetry(() -> cursor.putCursorProperty(bucketKey, String.valueOf(bucketId)), + ManagedLedgerException.BadVersionException.class).thenApply(__ -> bucketId); + } + + private CompletableFuture<Long> asyncCreateBucketSnapshot() { + TripleLongPriorityQueue priorityQueue = super.getPriorityQueue(); + if (priorityQueue.isEmpty()) { + return CompletableFuture.completedFuture(null); + } + long numMessages = 0; + + final long startLedgerId = lastMutableBucket.startLedgerId; + final long endLedgerId = lastMutableBucket.endLedgerId; + + List<SnapshotSegment> bucketSnapshotSegments = new ArrayList<>(); + List<SnapshotSegmentMetadata> segmentMetadataList = new ArrayList<>(); + Map<Long, BitSet> bitMap = new HashMap<>(); + SnapshotSegment.Builder snapshotSegmentBuilder = SnapshotSegment.newBuilder(); + SnapshotSegmentMetadata.Builder segmentMetadataBuilder = SnapshotSegmentMetadata.newBuilder(); + + long currentTimestampUpperLimit = 0; + while (!priorityQueue.isEmpty()) { + long timestamp = priorityQueue.peekN1(); + if (currentTimestampUpperLimit == 0) { + currentTimestampUpperLimit = timestamp + timeStepPerBucketSnapshotSegment - 1; + } + + long ledgerId = priorityQueue.peekN2(); + long entryId = priorityQueue.peekN3(); + + checkArgument(ledgerId >= startLedgerId && ledgerId <= endLedgerId); + + // Move first segment of bucket snapshot to sharedBucketPriorityQueue + if (segmentMetadataList.size() == 0) { + sharedBucketPriorityQueue.add(timestamp, ledgerId, entryId); + } + + priorityQueue.pop(); + numMessages++; + + DelayedIndex delayedIndex = DelayedIndex.newBuilder() + .setTimestamp(timestamp) + .setLedgerId(ledgerId) + .setEntryId(entryId).build(); + + if (entryId <= Integer.MAX_VALUE) { + bitMap.compute(ledgerId, (k, v) -> new BitSet()).set((int) entryId); + } + + snapshotSegmentBuilder.addIndexes(delayedIndex); + + if (priorityQueue.isEmpty() || priorityQueue.peekN1() > currentTimestampUpperLimit) { + segmentMetadataBuilder.setMaxScheduleTimestamp(timestamp); + currentTimestampUpperLimit = 0; + + Iterator<Map.Entry<Long, BitSet>> iterator = bitMap.entrySet().iterator(); + while (iterator.hasNext()) { + Map.Entry<Long, BitSet> entry = iterator.next(); + ByteString byteString = ByteString.copyFrom(entry.getValue().toByteArray()); + segmentMetadataBuilder.putDelayedIndexBitMap(entry.getKey(), byteString); + iterator.remove(); + } + + segmentMetadataList.add(segmentMetadataBuilder.build()); + segmentMetadataBuilder.clear(); + + bucketSnapshotSegments.add(snapshotSegmentBuilder.build()); + snapshotSegmentBuilder.clear(); + } + } + + SnapshotMetadata bucketSnapshotMetadata = SnapshotMetadata.newBuilder() + .addAllMetadataList(segmentMetadataList) + .build(); + + final int lastSegmentEntryId = segmentMetadataList.size(); + + Bucket bucket = this.createImmutableBucket(startLedgerId, endLedgerId); + bucket.setCurrentSegmentEntryId(1); + bucket.setNumberBucketDelayedMessages(numMessages); + bucket.setLastSegmentEntryId(lastSegmentEntryId); + + // Add the first snapshot segment last message to snapshotSegmentLastMessageTable + checkArgument(!bucketSnapshotSegments.isEmpty()); + SnapshotSegment snapshotSegment = bucketSnapshotSegments.get(0); + DelayedIndex delayedIndex = snapshotSegment.getIndexes(snapshotSegment.getIndexesCount() - 1); + snapshotSegmentLastIndexTable.put(delayedIndex.getLedgerId(), delayedIndex.getEntryId(), bucket); + + if (log.isDebugEnabled()) { + log.debug("[{}] Create bucket snapshot, bucket: {}", dispatcher.getName(), bucket); + } + + String bucketKey = bucket.bucketKey(); + CompletableFuture<Long> future = asyncSaveBucketSnapshot(bucketKey, + bucketSnapshotMetadata, bucketSnapshotSegments); + bucket.setSnapshotCreateFuture(future); + future.whenComplete((__, ex) -> { + if (ex == null) { + bucket.setSnapshotCreateFuture(null); + } else { + //TODO Record create snapshot failed + log.error("Failed to create snapshot: ", ex); + } + }); + + return future; + } + + + @SneakyThrows + private CompletableFuture<Void> asyncLoadNextBucketSnapshotEntry(Bucket bucket, boolean isRebuild) { + if (log.isDebugEnabled()) { + log.debug("[{}] Load next bucket snapshot data, bucket: {}", dispatcher.getName(), bucket); + } + if (bucket == null) { + return CompletableFuture.completedFuture(null); + } + + final CompletableFuture<Long> createFuture = bucket.snapshotCreateFuture; + if (createFuture != null) { + // Wait bucket snapshot create finish + createFuture.get(); + } + + final String bucketKey = bucket.bucketKey(); + final Long bucketId = getBucketIdByBucketKey(bucketKey); + Objects.requireNonNull(bucketId); + + CompletableFuture<Integer> loadMetaDataFuture = new CompletableFuture<>(); + if (isRebuild) { + final long cutoffTime = getCutoffTime(); + // Load Metadata of bucket snapshot + bucketSnapshotStorage.getBucketSnapshotMetadata(bucketId).thenAccept(snapshotMetadata -> { Review Comment: Move to another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
