tjiuming commented on code in PR #17398:
URL: https://github.com/apache/pulsar/pull/17398#discussion_r991831955
##########
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPoliciesImpl.java:
##########
@@ -178,7 +182,9 @@ public static OffloadPoliciesImpl create(String driver,
String region, String bu
String role, String
roleSessionName,
String credentialId, String
credentialSecret,
Integer maxBlockSizeInBytes,
Integer readBufferSizeInBytes,
- Long offloadThresholdInBytes,
Long offloadDeletionLagInMillis,
+ Long offloadThresholdInBytes,
+ //Long offloadTimeThreshold,
//TODO
Review Comment:
It's for the CLI and RestAPI, I'll remove here
##########
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPoliciesImpl.java:
##########
@@ -178,7 +182,9 @@ public static OffloadPoliciesImpl create(String driver,
String region, String bu
String role, String
roleSessionName,
String credentialId, String
credentialSecret,
Integer maxBlockSizeInBytes,
Integer readBufferSizeInBytes,
- Long offloadThresholdInBytes,
Long offloadDeletionLagInMillis,
+ Long offloadThresholdInBytes,
+ //Long offloadTimeThreshold,
//TODO
Review Comment:
It's for the CLI and RestAPI, I'll remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
