Demogorgon314 opened a new pull request, #44:
URL: https://github.com/apache/pulsar-client-cpp/pull/44

   ### Motivation
   
   Currently, some build guide is out-of-date. We need to update the build 
guide.
   
   The first issue is when we install the dependencies for Ubuntu, we still 
need manually compile and install google test and google mock. 
   
   However, we can use `libgmock-dev` to replace the `google-mock`, since the 
`libgmock-dev` already contains the static-link library.
   
   ```
   $ dpkg -L libgmock-dev
   // ...
   /usr/lib/x86_64-linux-gnu
   /usr/lib/x86_64-linux-gnu/libgmock.a
   /usr/lib/x86_64-linux-gnu/libgmock_main.a
   // ...
   ```
   
   Same as the `libgtest-dev`.
   
   ```
   $ dpkg -L libgtest-dev
   // ...
   /usr/lib/x86_64-linux-gnu/libgtest.a
   /usr/lib/x86_64-linux-gnu/libgtest_main.a
   // ...
   ```
   
   The second issue is macOS dependency. The `boost-python` has already been 
removed from the brew core. We should always use `boost-python3`.
   
   ```
   ~ brew info boost-python
   Error: No available formula with the name "boost-python". Did you mean 
boost-python3 or gst-python?
   ==> Searching for a previously deleted formula (in the last month)...
   Error: No previously deleted formula found.
   ```
   
   The third one is `OPENSSL_INCLUDE_DIR` and `OPENSSL_ROOT_DIR`. 
   For m1 macOS, the brew preferred prefix is `/opt/homebrew/opt`, Intel macOS 
is `/usr/local`.
   So we set the `OPENSSL_INCLUDE_DIR, OPENSSL_ROOT_DIR`. We should consider 
the different platforms.
   
   
   ### Modifications
   
   Fix Ubuntu and macOS build guide
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [ ] `doc-not-needed` 
   (Please explain why)
   
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to