eolivelli commented on code in PR #17922:
URL: https://github.com/apache/pulsar/pull/17922#discussion_r994738608
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarRegistrationClient.java:
##########
@@ -153,4 +212,56 @@ private static Set<BookieId>
convertToBookieAddresses(List<String> children) {
}
return newBookieAddrs;
}
+
+ @Override
+ public CompletableFuture<Versioned<BookieServiceInfo>>
getBookieServiceInfo(BookieId bookieId) {
Review Comment:
here (copied from #17913) we are waiting on the CompletableFuture returned
by this method.
but without this PR the CF is expected to be completed by the main metadata
store thread, that is already running the caller code
(BookkeeperSchemaStorage.lambda$openLedger)
```
t
java.util.concurrent.CompletableFuture.get([email protected]/CompletableFuture.java:1998)
at
org.apache.bookkeeper.common.concurrent.FutureUtils.result(FutureUtils.java:72)
at
org.apache.bookkeeper.common.concurrent.FutureUtils.result(FutureUtils.java:61)
at
org.apache.bookkeeper.client.DefaultBookieAddressResolver.resolve(DefaultBookieAddressResolver.java:43)
at
org.apache.bookkeeper.proto.PerChannelBookieClient.connect(PerChannelBookieClient.java:532)
at
org.apache.bookkeeper.proto.PerChannelBookieClient.connectIfNeededAndDoOp(PerChannelBookieClient.java:658)
at
org.apache.bookkeeper.proto.DefaultPerChannelBookieClientPool.initialize(DefaultPerChannelBookieClientPool.java:92)
at
org.apache.bookkeeper.proto.BookieClientImpl.lookupClient(BookieClientImpl.java:217)
```
it is really complicated to see because there are so many indirections.
But the problem is here in the end.
We had the very same problem in BK when initially I implemented
`getBookieServiceInfo` in the BK core code base (you can take a look there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
