michaeljmarshall commented on code in PR #286:
URL: https://github.com/apache/pulsar-helm-chart/pull/286#discussion_r998772076
##########
charts/pulsar/values.yaml:
##########
@@ -515,6 +519,10 @@ bookkeeper:
# type: pd-ssd
# fsType: xfs
# provisioner: kubernetes.io/gce-pd
+ ## If you want to bind static persistent volumes via selectors, e.g.:
+ # selectors:
+ # matchLabels:
+ # app: pulsar-bookkeeper-journal
Review Comment:
```suggestion
selector: {}
```
##########
charts/pulsar/values.yaml:
##########
@@ -383,6 +383,10 @@ zookeeper:
# type: pd-ssd
# fsType: xfs
# provisioner: kubernetes.io/gce-pd
+ ## If you want to bind static persistent volumes via selectors, e.g.:
+ # selectors:
+ # matchLabels:
+ # app: pulsar-zookeeper
Review Comment:
I think it is slightly more helpful to have a good zero value here. Also, we
need `selector` not `selectors`.
```suggestion
## If you want to bind static persistent volumes via selectors, e.g.:
selector: {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
