ericsyh commented on code in PR #18015: URL: https://github.com/apache/pulsar/pull/18015#discussion_r1001671632
########## site2/docs/helm-deploy.md: ########## @@ -284,15 +287,15 @@ To enable authorization, you can include this option in the `helm install` comma --set auth.authorization.enabled=true ``` -### CPU and RAM resource requirements +#### CPU and RAM resource requirements By default, the resource requests and the number of replicas for the Pulsar components in the Pulsar Helm chart are adequate for small production deployment. If you deploy a non-production instance, you can reduce the defaults to fit into a smaller cluster. Once you have all of your configuration options collected, you can install dependent charts before installing the Pulsar Helm chart. ## Install dependent charts -### Install local storage provisioner +#### Install local storage provisioner Review Comment: > It also has a counterpart in the [Persistence](https://pulsar.apache.org/docs/next/helm-deploy#persistence) section and even a parameter named local_storage. Should this part be updated as well? Yeah, I think this part should be updated also. `local_storage` config is for the `streamnative/local-storage-provisioner`. > Is create storage class and config the storage class an alternative way to install the storage provisioned compared to the [recommended cmd](https://pulsar.apache.org/docs/next/helm-deploy#install-local-storage-provisioner) in the doc, or a subsequent step? Creating a storage class and config the storage class is a more general way for storage provisioned. Actually, `helm install pulsar-storage-provisioner streamnative/local-storage-provisioner` is also to install `local-storage-provisioner` in kubernetes as a storage class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
