TakaHiR07 opened a new pull request, #18222:
URL: https://github.com/apache/pulsar/pull/18222

   Master Issue: #16768 
   
   ### Motivation
   
   The problem has been discussed before in 
[#16792](https://github.com/apache/pulsar/pull/16792). And now I found that 
when creating a topic with large partition such as 500 on a cluster which 
already has many topics, it would frequently update zk node,  put more pressure 
on zk, maybe result in zk node not available. Therefore I think we'd better fix 
this problem. 
   
   Since the discussion in #16792 , there are 2 ways to enhance  grant 
permission module. This is the second implementation, which I think is a better 
way to fix, and can have better compatibility with previous version.
   
   pulsar old version
   |  | partition (e.g., persistent://public/default/mytopic-partition-0) | 
based topic (e.g., persistent://public/default/mytopic)|
   | ------ | ------ | ------ |
   | grant | only partition | grant all partition and then grant based topic |
   | revoke | only partition | revoke all partition and then revoke based topic 
(it doesn't matter if revoke partition failed)  |
   | get | only partition | only based topic |
   | check | check partition and then check based topic | only based topic |
   
   pulsar new version
   |  | partition (e.g., persistent://public/default/mytopic-partition-0) | 
based topic (e.g., persistent://public/default/mytopic)|
   | ------ | ------ | ------ |
   | grant | only partition | only based topic |
   | revoke | only partition | revoke based topic and then revoke partition (it 
doesn't matter if revoke partition failed) |
   | get | only partition | only based topic |
   | check | check partition and then check based topic | only based topic |
   
   ### Modifications
   
   do not grant permission for each partition
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local 
preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR 
description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions 
will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since 
the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed 
in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments 
have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to