yyj8 commented on code in PR #18116:
URL: https://github.com/apache/pulsar/pull/18116#discussion_r1007512572
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java:
##########
@@ -70,7 +71,19 @@ public static void generate(PulsarService pulsar, boolean
includeTopicMetrics, b
LongAdder topicsCount = new LongAdder();
Review Comment:
Indeed, renaming the metrics name can not only have a clear meaning, but
also separate the data of the broker from that of the topic in the prometheus,
greatly improving the performance of querying the broker metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
