tongsucn commented on code in PR #66:
URL: https://github.com/apache/pulsar-client-cpp/pull/66#discussion_r1007566758
##########
lib/SharedBuffer.h:
##########
@@ -203,6 +203,13 @@ class SharedBuffer {
writeIdx_ = 0;
}
+ bool pop(std::string& target) {
+ if (data_ == nullptr) return false;
Review Comment:
Good point. Let me add a flag in `SharedBuffer` to denote if it's a
read-only one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
