liangyepianzhou commented on code in PR #17847:
URL: https://github.com/apache/pulsar/pull/17847#discussion_r1007677796
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -163,7 +150,10 @@ public void noNeedToRecover() {
// sync maxReadPosition change to LAC when
TopicTransaction buffer have not recover
// completely the normal message have been sent to
broker and state is
// not NoSnapshot can't sync maxReadPosition
- maxReadPosition = (PositionImpl)
topic.getManagedLedger().getLastConfirmedEntry();
+ snapshotAbortedTxnProcessor
+
.updateMaxReadPositionNotIncreaseChangeTimes(topic.getManagedLedger()
+ .getLastConfirmedEntry());
Review Comment:
Yes, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
