[GitHub] [pulsar-client-node] shibd commented on pull request #238: [feat] Support windows build napi of static link c++ lib.

Mon, 31 Oct 2022 03:47:24 -0700 


shibd commented on PR #238:
URL: 
https://github.com/apache/pulsar-client-node/pull/238#issuecomment-1296909950

   > 
![image](https://user-images.githubusercontent.com/18204803/198980261-5b4789b7-407a-43a5-9da6-138161435699.png)
   > 
   > You can see the PR validation only verified the case of x86 Windows and 
Node.js 16. The Node.js version compatibility checks should be performed when 
pushing a PR, not when pushing a tag.
   
   
   
   > 
![image](https://user-images.githubusercontent.com/18204803/198980261-5b4789b7-407a-43a5-9da6-138161435699.png)
   > 
   > You can see the PR validation only verified the case of x86 Windows and 
Node.js 16. The Node.js version compatibility checks should be performed when 
pushing a PR, not when pushing a tag.
   
   Yes, I added more verification conditions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to