nodece commented on code in PR #18218:
URL: https://github.com/apache/pulsar/pull/18218#discussion_r1010203387
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java:
##########
@@ -1398,15 +1398,18 @@ public void testSetOffloadThreshold() throws Exception {
System.out.println(namespace);
// set a default
pulsar.getConfiguration().setManagedLedgerOffloadAutoTriggerSizeThresholdBytes(1);
+
pulsar.getConfiguration().setManagedLedgerOffloadThresholdInSeconds(100);
// create the namespace
admin.namespaces().createNamespace(namespace,
Set.of(testLocalCluster));
admin.topics().createNonPartitionedTopic(topicName.toString());
admin.namespaces().setOffloadDeleteLag(namespace, 10000,
TimeUnit.SECONDS);
assertEquals(-1, admin.namespaces().getOffloadThreshold(namespace));
+ assertEquals(-1,
admin.namespaces().getOffloadThresholdInSeconds(namespace));
// assert we get the default which indicates it will fall back to
default
assertEquals(-1, admin.namespaces().getOffloadThreshold(namespace));
+ assertEquals(-1,
admin.namespaces().getOffloadThresholdInSeconds(namespace));
Review Comment:
```suggestion
assertEquals(admin.namespaces().getOffloadThresholdInSeconds(namespace), -1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
