codelipenghui commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1010359577
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1212,9 +1212,13 @@ public void getStats(
+ "not to use when there's heavy traffic.")
@QueryParam("subscriptionBacklogSize") @DefaultValue("false")
boolean subscriptionBacklogSize,
@ApiParam(value = "If return time of the earliest message in
backlog")
- @QueryParam("getEarliestTimeInBacklog") @DefaultValue("false")
boolean getEarliestTimeInBacklog) {
+ @QueryParam("getEarliestTimeInBacklog") @DefaultValue("false")
boolean getEarliestTimeInBacklog,
+ @ApiParam(value = "If return If return
TotalNonContiguousDeletedMessagesRange")
Review Comment:
Please check all.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1212,9 +1212,13 @@ public void getStats(
+ "not to use when there's heavy traffic.")
@QueryParam("subscriptionBacklogSize") @DefaultValue("false")
boolean subscriptionBacklogSize,
@ApiParam(value = "If return time of the earliest message in
backlog")
- @QueryParam("getEarliestTimeInBacklog") @DefaultValue("false")
boolean getEarliestTimeInBacklog) {
+ @QueryParam("getEarliestTimeInBacklog") @DefaultValue("false")
boolean getEarliestTimeInBacklog,
+ @ApiParam(value = "If return If return
TotalNonContiguousDeletedMessagesRange")
Review Comment:
```suggestion
@ApiParam(value = "If return the total non-continues deleted
message range")
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1435,14 +1437,15 @@ protected void
internalGetPartitionedStats(AsyncResponse asyncResponse, boolean
.thenCompose(owned -> {
if (owned) {
return getTopicReferenceAsync(partition)
- .thenApply(ref ->
- ref.getStats(getPreciseBacklog,
subscriptionBacklogSize,
- getEarliestTimeInBacklog));
+ .thenApply(ref ->
+
ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
Review Comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
