Demogorgon314 commented on code in PR #71:
URL: https://github.com/apache/pulsar-client-cpp/pull/71#discussion_r1012583780
##########
lib/ConsumerImpl.cc:
##########
@@ -319,6 +320,48 @@ void ConsumerImpl::unsubscribeAsync(ResultCallback
originalCallback) {
}
}
+void ConsumerImpl::triggerCheckExpiredChunkedTimer() {
+ checkExpiredChunkedTimer_->expires_from_now(
+
boost::posix_time::milliseconds(expireTimeOfIncompleteChunkedMessageMs_));
+ std::weak_ptr<ConsumerImplBase> weakSelf{shared_from_this()};
+ checkExpiredChunkedTimer_->async_wait([this, weakSelf](const
boost::system::error_code& ec) -> void {
+ auto self = weakSelf.lock();
+ if (!self) {
+ return;
+ }
+ if (ec) {
+ LOG_DEBUG(getName() << " Check expired chunked messages was failed
or cancelled, code[" << ec
+ << "].");
+ return;
+ }
+ Lock lock(chunkProcessMutex_);
+ long currentTimeMs = TimeUtils::currentTimeMillis();
+ chunkedMessageCache_.removeOldestValuesIf(
+ [this, ¤tTimeMs](const std::string& uuid, const
ChunkedMessageCtx& ctx) -> bool {
+ bool expired =
+ currentTimeMs > ctx.getReceivedTimeMs() +
expireTimeOfIncompleteChunkedMessageMs_;
+ if (!expired) {
+ return false;
+ }
+ for (const MessageId& msgId : ctx.getChunkedMessageIds()) {
+ if (autoAckOldestChunkedMessageOnQueueFull_) {
Review Comment:
I just checked the Java client. It always auto-ack when the message expires.
Do we need to follow the Java client behavior?
Also, this config is a little confusing here. It should be auto ack expires
chunked message, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
