WJL3333 commented on code in PR #18325:
URL: https://github.com/apache/pulsar/pull/18325#discussion_r1013210958
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java:
##########
@@ -184,11 +184,7 @@ public CompletableFuture<Consumer<T>> subscribeAsync() {
public ConsumerBuilder<T> topic(String... topicNames) {
checkArgument(topicNames != null && topicNames.length > 0,
"Passed in topicNames should not be null or empty.");
- Arrays.stream(topicNames).forEach(topicName ->
- checkArgument(StringUtils.isNotBlank(topicName), "topicNames
cannot have blank topic"));
-
conf.getTopicNames().addAll(Arrays.stream(topicNames).map(StringUtils::trim)
- .collect(Collectors.toList()));
- return this;
+ return topics(Arrays.stream(topicNames).collect(Collectors.toList()));
Review Comment:
we can use `Stream.toList` here, this api is introduce in jdk 16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
