michaeljmarshall commented on code in PR #18015:
URL: https://github.com/apache/pulsar/pull/18015#discussion_r1014471393
##########
site2/docs/helm-deploy.md:
##########
@@ -131,49 +128,49 @@ The Pulsar Helm chart is designed to enable controlled
upgrades. So it can confi
images:
zookeeper:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
bookie:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
autorecovery:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
broker:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
proxy:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
functions:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
prometheus:
repository: prom/prometheus
- tag: v1.6.3
+ tag: v2.17.2
pullPolicy: IfNotPresent
grafana:
repository: streamnative/apache-pulsar-grafana-dashboard-k8s
- tag: 0.0.4
+ tag: 0.0.16
pullPolicy: IfNotPresent
Review Comment:
We no longer deploy these components this way. We can remove this section.
Configuration for prometheus and grafana is governed by
https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack.
It just needs to be in the `kube-prometheus-stack:` section of the values.yaml
file.
##########
site2/docs/helm-deploy.md:
##########
@@ -330,19 +323,15 @@ cd pulsar-helm-chart
The `prepare_helm_release` creates the following resources:
Review Comment:
This script was not maintained, so it was removed from the README here
https://github.com/apache/pulsar-helm-chart/pull/324. There are appropriate
instructions in that PR that could be copied to this section. The current
README in https://github.com/apache/pulsar-helm-chart should work, too.
##########
site2/docs/helm-deploy.md:
##########
@@ -131,47 +134,47 @@ The Pulsar Helm chart is designed to enable controlled
upgrades. So it can confi
images:
zookeeper:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
bookie:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
autorecovery:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
broker:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
proxy:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
pullPolicy: IfNotPresent
functions:
repository: apachepulsar/pulsar-all
- tag: 2.5.0
+ tag: @pulsar:version@
prometheus:
Review Comment:
This section looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
