coderzc commented on code in PR #18315:
URL: https://github.com/apache/pulsar/pull/18315#discussion_r1014969014
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStreamingDispatcherMultipleConsumers.java:
##########
@@ -113,12 +113,14 @@ public synchronized void readEntryComplete(Entry entry,
PendingReadEntryRequest
// in a separate thread, and we want to prevent more reads
sendInProgress = true;
dispatchMessagesThread.execute(safeRun(() -> {
- if (sendMessagesToConsumers(readType,
Lists.newArrayList(entry), ctx.isLast())) {
+ if (sendMessagesToConsumers(readType,
Lists.newArrayList(entry),
+ readType == ReadType.Normal || ctx.isLast())) {
Review Comment:
You are right, I try to separate the `sendInProgress` and
`sendInProgressReplay`, make `sendInProgress` of normal type read don't affect
`sendInProgressReplay` of replay type read. Please look at it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
