yaalsn commented on code in PR #18359:
URL: https://github.com/apache/pulsar/pull/18359#discussion_r1015046624
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java:
##########
@@ -124,7 +124,12 @@ private static Provider loadConscryptProvider() {
conscryptClazz = Class.forName("org.conscrypt.Conscrypt");
conscryptClazz.getMethod("checkAvailability").invoke(null);
} catch (Throwable e) {
- log.warn("Conscrypt isn't available. Using JDK default security
provider.", e);
+ if (e.getCause() != null &&
e.getCause().getClass().getName().equals("java.lang.UnsatisfiedLinkError")) {
Review Comment:
It's better to use level `warn` because it is a exception — not a `If -
else` or something needs to record. This `warn` means conscrypt is not
supported which needs to remind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
