heesung-sn commented on PR #18084:
URL: https://github.com/apache/pulsar/pull/18084#issuecomment-1307504956
Hi,
I am not sure pulsar follows this naming convention, but I think we can
make a creative name for this project and use it as the package name, like
org.apache.pulsar.broker.loadbalance.(project name).
I propose “Overlord”.
org.apache.pulsar.broker.loadbalance.overlord
Origin:
https://starcraft.fandom.com/wiki/Overlord
I am also ok with
org.apache.pulsar.broker.loadbalance.extensions or
org.apache.pulsar.broker.loadbalance.extensible.
Thanks,
Heesung
On Tue, Nov 8, 2022 at 5:19 AM Kai Wang ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In
>
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensible/BrokerRegistry.java
> <https://github.com/apache/pulsar/pull/18084#discussion_r1016623764>:
>
> > + * distributed with this work for additional information
> + * regarding copyright ownership. The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied. See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
> +package org.apache.pulsar.broker.loadbalance.extensible;
>
> I will more prefer to use org.apache.pulsar.broker.loadbalance.extensions
> or org.apache.pulsar.broker.loadbalance.extensible.
>
> @heesung-sn <https://github.com/heesung-sn> Do you have any other
> opinions?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/pulsar/pull/18084#discussion_r1016623764>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AYVJ675AMK74H72NFMJEDUTWHJHPTANCNFSM6AAAAAARHZDICI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
