tisonkun commented on code in PR #18385:
URL: https://github.com/apache/pulsar/pull/18385#discussion_r1018185105
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/netty/EventLoopUtil.java:
##########
@@ -35,43 +35,61 @@
import io.netty.channel.socket.nio.NioDatagramChannel;
import io.netty.channel.socket.nio.NioServerSocketChannel;
import io.netty.channel.socket.nio.NioSocketChannel;
+import io.netty.incubator.channel.uring.IOUring;
+import io.netty.incubator.channel.uring.IOUringDatagramChannel;
+import io.netty.incubator.channel.uring.IOUringEventLoopGroup;
+import io.netty.incubator.channel.uring.IOUringServerSocketChannel;
+import io.netty.incubator.channel.uring.IOUringSocketChannel;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ThreadFactory;
import lombok.extern.slf4j.Slf4j;
import org.apache.bookkeeper.common.util.affinity.CpuAffinity;
+import org.apache.commons.lang3.StringUtils;
@SuppressWarnings("checkstyle:JavadocType")
@Slf4j
public class EventLoopUtil {
+ private static final String ENABLE_IO_URING = "enable.io_uring";
Review Comment:
I'm wondering whether we need a prefix here, or if it's the same as how
netty does it.
That said, if it's a Pulsar specific property, name it as:
```java
private static final String ENABLE_IO_URING_KEY = "pulsar.enableUring";
```
can avoid accidental conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
