shibd commented on code in PR #105:
URL: https://github.com/apache/pulsar-client-cpp/pull/105#discussion_r1019832377


##########
lib/MessageBatch.cc:
##########
@@ -47,7 +47,7 @@ MessageBatch& MessageBatch::parseFrom(const SharedBuffer& 
payload, uint32_t batc
     batch_.clear();
 
     for (int i = 0; i < batchSize; ++i) {
-        
batch_.push_back(Commands::deSerializeSingleMessageInBatch(batchMessage_, i));
+        
batch_.push_back(Commands::deSerializeSingleMessageInBatch(batchMessage_, i, 
batchSize));

Review Comment:
   Have a question: What is the role of `MessageBatch`, Doesn't seem to find a 
place to use it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to