[GitHub] [pulsar] Jason918 commented on a diff in pull request #18245: InflightReadsLimiter - limit the memory used by reads end-to-end (from storage/cache to the write to the consumer channel)

Fri, 11 Nov 2022 01:48:19 -0800 


Jason918 commented on code in PR #18245:
URL: https://github.com/apache/pulsar/pull/18245#discussion_r1020054728


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryImpl.java:
##########
@@ -44,6 +44,8 @@ protected EntryImpl newObject(Handle<EntryImpl> handle) {
     private long entryId;
     ByteBuf data;
 
+    private Runnable onDeallocate;

Review Comment:
   This is not volatile, but it seems that `deallocate()` could be called in 
other threads?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to