shibd opened a new pull request, #117:
URL: https://github.com/apache/pulsar-client-cpp/pull/117

   ### Motivation
   
   There is a problem with the `getLastMessageId` method currently implemented.
   
   He is recursively invoking himself.
   
https://github.com/apache/pulsar-client-cpp/blob/ad79becf0814a992ad493bc625ba0a489900451f/lib/Consumer.cc#L293-L301
   
   ### Modifications
   
   - Let it call the actual implementation.
   
   **Note**:  `MultiTopicConsumer.getLastMessageId()` is not supported for the 
time being. I will support it later. Supporting `MultiTopicConsumer` requires 
the implementation of 
[MultiMessageId](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiMessageIdImpl.java),
 which requires more thought and design.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to