heesung-sn commented on PR #18254: URL: https://github.com/apache/pulsar/pull/18254#issuecomment-1312084363
@equanz, Thank you for sharing the example. Although it is not desirable, I think we could be more lenient on this stat API change(assuming this `publishers` stat struct is used for human admins only for ad-hoc checks). If this breaking change is not acceptable, I guess we could push this to the next major version. Also for the next major version, when there are more than thousands of producers(consumers) for a (partitioned-)topic, it is expensive to aggregate each publisher(subscriptions)'s stats on-the-fly across the brokers. I think we could further define producers(subscriptions)' API like the below and drop the `publishers` and `subscriptions` structs from `topics (partitioned-)stats` returns. ``` pulsar-admin publishers list my-topic --last-pagination-key xyz pulsar-admin publishers stats my-producer # similarly for subscriptions ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
