poorbarcode commented on PR #18418:
URL: https://github.com/apache/pulsar/pull/18418#issuecomment-1318059846

   Hi @AnonHxy 
   > It make sense to me. It seems that we could just remove the following from 
the test case, and keep others unchanged
   
   ```
    LocalBrokerData data = loadManager.getLoadManager().updateLocalBrokerData();
    data.cleanDeltas();
    data.getBundles().clear();
   ```
   > WDYT @poorbarcode
   
   I don't know why `data.clear` should executed in this place (-_-)
   
   > @poorbarcode do you have any other comments?:)
   
   I think the concurrent operation was caused by the test case, so there is no 
need to change the collection to be thread-safe. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to