BewareMyPower commented on PR #10601: URL: https://github.com/apache/pulsar/pull/10601#issuecomment-1319501354
This PR was included in 2.8.0 and didn't break the compatibility with 2.7.x because https://github.com/apache/pulsar/pull/4963 introduced a query param `checkAllowAutoCreation` in HTTP client. Actually #4963 introduced a breaking change (`allowAutoTopicCreationType=partitioned`) so that the query param was added. The breaking change has been reverted in https://github.com/apache/pulsar/pull/5308 (`allowAutoTopicCreationType=non-partitioned`), but the client side changes are not reverted. The C++ client tests should expose the breaking change because there was no `checkAllowAutoCreation` in C++ client before https://github.com/apache/pulsar/pull/11557. Unfortunately, the CI in master was accidentally broken at that time (see https://github.com/apache/pulsar/pull/11575) so the C++ client tests passed. I agree that it's a breaking change. But this new behavior is also needed in some cases to differ a non-partitioned topic and a non-existent topic. I prefer to add a new config to keep the compatibility for old version clients. Reverting this PR would also bring many breaking changes for those external systems that depend on Pulsar 2.8.0 or later. @rdhabalia @eolivelli I will send an mail to dev and reference the discussion here soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
