momo-jun commented on PR #18585: URL: https://github.com/apache/pulsar/pull/18585#issuecomment-1325863339
Hi @DaveDuggins, fyi - I've fixed the following syntax/style issues, including: 1. Use double quotes `"` instead of `“` for the `sidebar_label` field in the `reference-landing.md` file. 2. Use `---` instead of `-` following the `sidebar_label` field in the `reference-landing.md` file. 3. Add `reference-landing` to the left navigation by updating the `sidebars.json` file. The preview cannot succeed due to issues 1&2. Now it works as follows: <img width="1417" alt="image" src="https://user-images.githubusercontent.com/60642177/203679447-19d5d0b2-087d-4767-8824-f2c5aed9246d.png"> Another suggestion is - Create a separate PR in your forked repo for a new batch of changes. Currently, you are using the `master` branch of your repo as usual, so there is a long list of commit history, which is not necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
