heesung-sn commented on code in PR #18195:
URL: https://github.com/apache/pulsar/pull/18195#discussion_r1033147317


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewConfigurationData.java:
##########
@@ -29,13 +29,15 @@ public class TableViewConfigurationData implements 
Serializable, Cloneable {
 
     private String topicName = null;
     private long autoUpdatePartitionsSeconds = 60;
+    private String topicCompactionStrategy;

Review Comment:
   > How will the broker know which strategy should use? Or it just happened on 
the client side. For the broker side, we need to set the strategy by setting 
topic policies.
   
   client can configure any matching topic compaction strategy if the user 
knows the compaction class name.
   
   Right, on the broker side, ideally we can eventually set the compaction 
class name in the topic policy.
   
   But for pip192 i think we could start with a simple hashmap (topicname-> 
compact strategy) for the new load balancer's internal system topic to use the 
compaction strategy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to