michaeljmarshall commented on code in PR #336: URL: https://github.com/apache/pulsar-helm-chart/pull/336#discussion_r1034043839
########## charts/pulsar/values.yaml: ########## @@ -281,7 +281,7 @@ zookeeper: # so the metrics are correctly rendered in grafana dashboard component: zookeeper # the number of zookeeper servers to run. it should be an odd number larger than or equal to 3. - replicaCount: 1 + replicaCount: 3 Review Comment: We already provide an example for a minikube deployment https://github.com/apache/pulsar-helm-chart/blob/master/examples/values-minikube.yaml. That configuration overrides this value. I agree that 3 makes more sense here, and I agree this is essentially a "breaking" change. I would prefer to merge this and go to 3.1.0 and call it out in the release notes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
