tisonkun commented on code in PR #18774:
URL: https://github.com/apache/pulsar/pull/18774#discussion_r1042902671
##########
pulsar-io/jdbc/clickhouse/pom.xml:
##########
@@ -38,7 +38,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>ru.yandex.clickhouse</groupId>
+ <groupId>com.clickhouse</groupId>
Review Comment:
Thanks for your review @zhicwu!
What's the most common dependency conflict that can be avoided by using the
shaded jar?
I can see using the basic JAR, the final connector NAR is in size 9.7M, and
after switching to the shaded jar, it grows to 46M.
If no user reports the current solution's issue, I tend to keep it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
