mattisonchao opened a new pull request, #18816:
URL: https://github.com/apache/pulsar/pull/18816
### Motivation
This regression was introduced by #16234; I found it by setting
`proxyAdditionalServlets ` on the proxy, but it didn't work. the reason is the
`proxyConfig.getProperties().getProperty("proxyAdditionalServlets")` returns
`null` after invoking `PulsarConfigurationLoader#convertFrom`.
The RC is the source config and the new config uses the same properties then
we set the unknown field to the new config without any type check. I'm not sure
if it's better to add the check here, but ignore to use the properties field
can fix the regression.
### Modifications
- Don't use the same properties object when converting.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
