BewareMyPower commented on code in PR #12104: URL: https://github.com/apache/pulsar/pull/12104#discussion_r1046796583
########## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProvider.java: ########## @@ -61,7 +87,9 @@ public interface AuthenticationProvider extends Closeable { * @return the "role" string for the authenticated connection, if the authentication was successful * @throws AuthenticationException * if the credentials are not valid + * @deprecated use and implement {@link AuthenticationProvider#authenticateAsync(AuthenticationDataSource)} instead. */ + @Deprecated Review Comment: It's weird that this PR should have been reverted in https://github.com/apache/pulsar/pull/14424, but it still exists in master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org