michaeljmarshall commented on code in PR #12104:
URL: https://github.com/apache/pulsar/pull/12104#discussion_r1048060550
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProvider.java:
##########
@@ -61,7 +87,9 @@ public interface AuthenticationProvider extends Closeable {
* @return the "role" string for the authenticated connection, if the
authentication was successful
* @throws AuthenticationException
* if the credentials are not valid
+ * @deprecated use and implement {@link
AuthenticationProvider#authenticateAsync(AuthenticationDataSource)} instead.
*/
+ @Deprecated
Review Comment:
@BewareMyPower - I am not sure of the right way to proceed here. I had plans
to complete the work for PIP 97, but I haven't been able to do so. I reverted
it from `branch-2.10` because the necessary implementation for making the
`ServerCnx` and the http filter async was not in place. I will think about this
some more and try to find the right approach.
Note that this PIP isn't needed unless you're doing something blocking when
`authenticate` is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
