dlg99 commented on code in PR #18989:
URL: https://github.com/apache/pulsar/pull/18989#discussion_r1052704024
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -937,7 +937,7 @@ public TransactionPendingAckStats getStats(boolean
lowWaterMarks) {
return transactionPendingAckStats;
}
- public synchronized void completeHandleFuture() {
+ public void completeHandleFuture() {
if (!this.pendingAckHandleCompletableFuture.isDone()) {
this.pendingAckHandleCompletableFuture.complete(PendingAckHandleImpl.this);
}
Review Comment:
do we need this check?
CompleteableFuture can be completed only once (API contract + implementation
confirms this), if needed one can use return value of complete() to check if it
succeeded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
