BewareMyPower commented on code in PR #19031:
URL: https://github.com/apache/pulsar/pull/19031#discussion_r1059282261
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -204,6 +208,10 @@
private final AtomicReference<ClientCnx>
clientCnxUsedForConsumerRegistration = new AtomicReference<>();
private final List<Throwable> previousExceptions = new
CopyOnWriteArrayList<Throwable>();
+ // Key is the ledger id and the entry id, entry is the acker that
represents which single messages are acknowledged
+ private final ConcurrentNavigableMap<Pair<Long, Long>, BatchMessageAcker>
batchMessageToAcker =
Review Comment:
> You will get the message again, but with a different Acker after the seek
operation.
This "correct" behavior requires you to acknowledge the new messages instead
of the old message ids. For example, the following code is the "wrong" behavior:
```java
var msgIds = new ArrayList<MessageId>();
for (int i = 0; i < 3; i++) {
msgIds.add(consumer.receive().getMessageId());
}
consumer.acknowledge(msgIds.get(0));
consumer.acknowledge(msgIds.get(2));
consumer.seek(Message.earliest);
consumer.acknowledge(msgIds.get(1));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
