michaeljmarshall commented on code in PR #19053:
URL: https://github.com/apache/pulsar/pull/19053#discussion_r1060873047


##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/impl/BacklogQuotaImpl.java:
##########
@@ -80,12 +80,12 @@ public void setLimitSize(long limitSize) {
         this.limit = limitSize;
     }
 
-    public int getLimitTime() {
-        return limitTime;
+    public int getLimitTimeInSec() {

Review Comment:
   I agree with that approach. There are many names in Pulsar that are slightly 
confusing. It'd make more sense to define a paradigm for naming before making 
many one-off changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to