This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.10 by this push:
new 74f40c9df2f [improve][broker] Added isActive in ManagedCursorImpl
(#19341)
74f40c9df2f is described below
commit 74f40c9df2f7f9237e891b85018772ca4e5ea713
Author: Heesung Sohn <[email protected]>
AuthorDate: Sat Jan 28 08:37:13 2023 -0800
[improve][broker] Added isActive in ManagedCursorImpl (#19341)
---
.../apache/bookkeeper/mledger/impl/ManagedCursorImpl.java | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
index 143750bcc49..71948f547c2 100644
---
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
+++
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
@@ -201,6 +201,9 @@ public class ManagedCursorImpl implements ManagedCursor {
private int individualDeletedMessagesSerializedSize;
private static final String COMPACTION_CURSOR_NAME = "__compaction";
+ // active state cache in ManagedCursor. It should be in sync with the
state in activeCursors in ManagedLedger.
+ private volatile boolean isActive = false;
+
class MarkDeleteEntry {
final PositionImpl newPosition;
final MarkDeleteCallback callback;
@@ -1102,19 +1105,23 @@ public class ManagedCursorImpl implements ManagedCursor
{
@Override
public void setActive() {
- if (!alwaysInactive) {
+ if (!isActive && !alwaysInactive) {
ledger.activateCursor(this);
+ isActive = true;
}
}
@Override
public boolean isActive() {
- return ledger.isCursorActive(this);
+ return isActive;
}
@Override
public void setInactive() {
- ledger.deactivateCursor(this);
+ if (isActive) {
+ ledger.deactivateCursor(this);
+ isActive = false;
+ }
}
@Override