BewareMyPower commented on code in PR #154:
URL: https://github.com/apache/pulsar-client-cpp/pull/154#discussion_r1098099246
##########
lib/MultiTopicsConsumerImpl.h:
##########
@@ -53,10 +54,15 @@ class MultiTopicsConsumerImpl : public ConsumerImplBase {
public:
MultiTopicsConsumerImpl(ClientImplPtr client, TopicNamePtr topicName, int
numPartitions,
const std::string& subscriptionName, const
ConsumerConfiguration& conf,
- LookupServicePtr lookupServicePtr);
+ LookupServicePtr lookupServicePtr,
+ const Commands::SubscriptionMode =
Commands::SubscriptionModeDurable,
+ boost::optional<MessageId> startMessageId =
boost::none);
+
MultiTopicsConsumerImpl(ClientImplPtr client, const
std::vector<std::string>& topics,
const std::string& subscriptionName, TopicNamePtr
topicName,
- const ConsumerConfiguration& conf,
LookupServicePtr lookupServicePtr_);
+ const ConsumerConfiguration& conf,
LookupServicePtr lookupServicePtr_,
+ const Commands::SubscriptionMode =
Commands::SubscriptionModeDurable,
Review Comment:
```suggestion
Commands::SubscriptionMode =
Commands::SubscriptionModeDurable,
```
##########
lib/MultiTopicsConsumerImpl.h:
##########
@@ -53,10 +54,15 @@ class MultiTopicsConsumerImpl : public ConsumerImplBase {
public:
MultiTopicsConsumerImpl(ClientImplPtr client, TopicNamePtr topicName, int
numPartitions,
const std::string& subscriptionName, const
ConsumerConfiguration& conf,
- LookupServicePtr lookupServicePtr);
+ LookupServicePtr lookupServicePtr,
+ const Commands::SubscriptionMode =
Commands::SubscriptionModeDurable,
Review Comment:
```suggestion
Commands::SubscriptionMode =
Commands::SubscriptionModeDurable,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
