asafm commented on code in PR #19235:
URL: https://github.com/apache/pulsar/pull/19235#discussion_r1111253248
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1284,7 +1289,11 @@ public void getPartitionedStats(
@ApiParam(value = "If return the earliest time in backlog")
@QueryParam("getEarliestTimeInBacklog") @DefaultValue("false")
boolean getEarliestTimeInBacklog) {
try {
- validatePartitionedTopicName(tenant, namespace, encodedTopic);
+ validateTopicName(tenant, namespace, encodedTopic);
Review Comment:
So now I can ask: What's the motivation for essentially copying the code
from within `validatePartitionedTopicName` (which still exists in the code, as
the method itself wasn't deleted) and pasting it in mutliple places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
