Demogorgon314 commented on code in PR #19560:
URL: https://github.com/apache/pulsar/pull/19560#discussion_r1112987276
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java:
##########
@@ -233,5 +237,23 @@ private Pair<Boolean, String> getMaxUsageBroker(
}
return Pair.of(hasBrokerBelowLowerBound, maxUsageBrokerName);
}
+ @Override
+ public void onBrokerChange(Set<String> newBrokers) {
+ synchronized (activeBrokers) {
+ activeBrokers.clear();
+ activeBrokers.addAll(newBrokers);
+ }
+ }
+
+ private void cleanUnActiveBroker() {
+ if (!activeBrokers.isEmpty()) {
+ synchronized (activeBrokers) {
+ if (!activeBrokers.isEmpty()) {
+ brokerAvgResourceUsage.keySet().removeIf((key) ->
!activeBrokers.contains(key));
Review Comment:
I see. Can we change the `brokerAvgResourceUsage` to `ConcurrentHashMap`,
and remove the inactive broker in the `onBrokerChange` method?
```
@Override
public void onBrokerChange(Set<String> newBrokers) {
brokerAvgResourceUsage.keySet().retainAll(newBrokers);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
