codelipenghui commented on code in PR #19615:
URL: https://github.com/apache/pulsar/pull/19615#discussion_r1118191253
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/DelayedDeliveryTest.java:
##########
@@ -479,7 +479,7 @@ public void testClearDelayedMessagesWhenClearBacklog()
throws PulsarClientExcept
Producer<String> producer = pulsarClient.newProducer(Schema.STRING)
.topic(topic).create();
- final int messages = 100;
+ final int messages = 10;
Review Comment:
Is it related to this PR?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTrackerFactory.java:
##########
@@ -63,7 +64,7 @@ public void initialize(PulsarService pulsarService) throws
Exception {
public DelayedDeliveryTracker
newTracker(PersistentDispatcherMultipleConsumers dispatcher) {
return new BucketDelayedDeliveryTracker(dispatcher, timer,
tickTimeMillis, isDelayedDeliveryDeliverAtTimeStrict,
bucketSnapshotStorage, delayedDeliveryMinIndexCountPerBucket,
- delayedDeliveryMaxTimeStepPerBucketSnapshotSegmentSeconds,
+
TimeUnit.SECONDS.toMillis(delayedDeliveryMaxTimeStepPerBucketSnapshotSegmentSeconds),
Review Comment:
We should change `timeStepPerBucketSnapshotSegment` in
`BucketDelayedDeliveryTracker` to `timeStepPerBucketSnapshotSegmentInMillis`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
