dlg99 opened a new pull request, #19772:
URL: https://github.com/apache/pulsar/pull/19772

   ### Motivation
   
   KCA's SourceConnector uses Kafka's task name as a parameter and creates the 
task directly.
   this works well enough for simpler or old sources (e.g. deebzium's 
potgre/mysql/mongo etc).
   Actual expected life cycle is to create a connector, then get the task class 
and the task config from it.
   Connectors that rely on such cycle do not work with KCA, e.g. yugabyte's 
debezium source. See 
   https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1677506713032549 for 
details.
   
   ### Modifications
   
   Added option to pass source connector's class name, made use of it.
   Kept the KCA compatible with old configuration, falling back to the legacy 
behavior if the config is not set.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added unit test.
   
   ### Does this pull request potentially affect one of the following parts:
   
   NO
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to