congbobo184 commented on code in PR #19767:
URL: https://github.com/apache/pulsar/pull/19767#discussion_r1133399279
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImplementationBindingImpl.java:
##########
@@ -252,7 +252,11 @@ public <K, V> Schema<KeyValue<K, V>>
newKeyValueSchema(Class<K> key, Class<V> va
}
public Schema<?> getSchema(SchemaInfo schemaInfo) {
- return AutoConsumeSchema.getSchema(schemaInfo);
+ if (schemaInfo.getType() == SchemaType.PROTOBUF) {
Review Comment:
if change this method is, it is a breaking change. I suggest adding a new
method in `AutoProduceBytesSchema`
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericSchemaImpl.java:
##########
@@ -73,6 +73,7 @@ public static GenericSchemaImpl of(SchemaInfo schemaInfo) {
public static GenericSchemaImpl of(SchemaInfo schemaInfo,
boolean
useProvidedSchemaAsReaderSchema) {
switch (schemaInfo.getType()) {
+ case PROTOBUF:
Review Comment:
don't change this method, because `GenericSchemaImpl` don't support PROTOBUF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
