rdhabalia commented on code in PR #19867:
URL: https://github.com/apache/pulsar/pull/19867#discussion_r1143698582
##########
pulsar-client-messagecrypto-bc/src/main/java/org/apache/pulsar/client/impl/crypto/MessageCryptoBc.java:
##########
@@ -314,7 +314,7 @@ private void addPublicKeyCipher(String keyName,
CryptoKeyReader keyReader) throw
pubKey = loadPublicKey(keyInfo.getKey());
} catch (Exception e) {
String msg = logCtx + "Failed to load public key " + keyName + ".
" + e.getMessage();
- log.error(msg);
+ log.error(msg, e);
Review Comment:
I don't see any issue to print error message as it's useful to create
monitoring alerts. so, printing message should exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
