poorbarcode commented on code in PR #19014:
URL: https://github.com/apache/pulsar/pull/19014#discussion_r1057408809
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java:
##########
@@ -99,10 +99,10 @@ public long getAvailableDispatchRateLimitOnByte() {
*/
public boolean tryDispatchPermit(long msgPermits, long bytePermits) {
boolean acquiredMsgPermit = msgPermits <= 0 ||
dispatchRateLimiterOnMessage == null
- // acquiring permits must be < configured msg-rate;
+ // In dispatch mode, acquiring permits can be larger than configured
msg-rate.
Review Comment:
> dispatch mode represents what? it is singleDispatcher and multiDispatcher,
right?
Yes, I have removed these two java-doc because it is outedated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
