heesung-sn commented on code in PR #19851:
URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144963549
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -1445,23 +1451,44 @@ public PulsarClientImpl
getNamespaceClient(ClusterDataImpl cluster) {
});
}
- public Optional<NamespaceEphemeralData> getOwner(NamespaceBundle bundle)
throws Exception {
- // if there is no znode for the service unit, it is not owned by any
broker
- return
getOwnerAsync(bundle).get(pulsar.getConfiguration().getMetadataStoreOperationTimeoutSeconds(),
SECONDS);
- }
-
public CompletableFuture<Optional<NamespaceEphemeralData>>
getOwnerAsync(NamespaceBundle bundle) {
+ if (ExtensibleLoadManagerImpl.isLoadManagerExtensionEnabled(config)) {
+ ExtensibleLoadManagerImpl extensibleLoadManager =
ExtensibleLoadManagerImpl.get(loadManager.get());
+ return
extensibleLoadManager.getOwnershipWithLookupDataAsync(bundle)
+ .thenCompose(lookupData -> {
+ if (lookupData.isPresent()) {
+ return CompletableFuture.completedFuture(
+
Optional.of(lookupData.get().toNamespaceEphemeralData()));
+ } else {
+ return
CompletableFuture.completedFuture(Optional.empty());
+ }
+ });
+ }
return ownershipCache.getOwnerAsync(bundle);
}
+ public boolean checkOwnershipPresent(NamespaceBundle bundle) throws
Exception {
+ return checkOwnershipPresentAsync(bundle).get(pulsar.getConfiguration()
+ .getMetadataStoreOperationTimeoutSeconds(), SECONDS);
+ }
+
+ public CompletableFuture<Boolean>
checkOwnershipPresentAsync(NamespaceBundle bundle) {
+ if (ExtensibleLoadManagerImpl.isLoadManagerExtensionEnabled(config)) {
+ ExtensibleLoadManagerImpl extensibleLoadManager =
ExtensibleLoadManagerImpl.get(loadManager.get());
+ return extensibleLoadManager.getOwnershipAsync(Optional.empty(),
bundle)
Review Comment:
Another option might be using a different namespace to isolate the load
manager topics. (e.g system-load-balance/) In this case, we need to schedule
compaction separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
