chrisjohnson00 commented on PR #356: URL: https://github.com/apache/pulsar-helm-chart/pull/356#issuecomment-1487748662
> LGTM. Thanks for your contribution @chrisjohnson00! > > The change to run the container as a non-root user broke this part of the helm chart. Another option would be to let the proxy service continue using ports 80 and 443 while mapping those to 8080 and 8443 on the proxy container. I don't think that is necessary though if we correctly document this change in the release notes. Oh, I hadn't noticed that both the service and the deployment shared these values. Wouldn't this make it a breaking change since the service ports would change? I'd be happy to update it so it is not a BC! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
