lifepuzzlefun commented on code in PR #19944:
URL: https://github.com/apache/pulsar/pull/19944#discussion_r1161072141
##########
pulsar-common/src/main/proto/PulsarApi.proto:
##########
@@ -62,9 +62,9 @@ message MessageIdData {
optional int32 batch_index = 4 [default = -1];
repeated int64 ack_set = 5;
optional int32 batch_size = 6;
-
// For the chunk message id, we need to specify the first chunk message id.
optional MessageIdData first_chunk_message_id = 7;
+ optional string topicName = 8;
Review Comment:
hi, i come from Kafka. and i think when client enable group commit offset.
the field can be group by topicName and we can have much smaller RPC message to
send on the wire. see kafka OffsetCommit RPC
https://kafka.apache.org/protocol.html#The_Messages_OffsetCommit : - )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
